-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpine-based docker image #609
Conversation
.circleci/config.yml
Outdated
- build: | ||
filters: | ||
tags: | ||
only: /.*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to use workflow to have circleci run also for tags.
Codecov Report
@@ Coverage Diff @@
## develop #609 +/- ##
===========================================
+ Coverage 36.98% 37.15% +0.17%
===========================================
Files 21 21
Lines 2893 2893
===========================================
+ Hits 1070 1075 +5
+ Misses 1728 1724 -4
+ Partials 95 94 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly, but I think you should probably merge this into #607
…sops:vX.X-alpine", "mozilla/sops:vX-alpine", and "mozilla/sops:alpine"
5ab23f4
to
31d62bc
Compare
Thanks for working on this :) |
Thanks! |
* Add Dockerfile.alpine * Publish alpine containers as "mozilla/sops:vX.X.X-alpine", "mozilla/sops:vX.X-alpine", "mozilla/sops:vX-alpine", and "mozilla/sops:alpine"
Replaces #604 .
I want alpine-based docker images for sops, as it's small and easy to use:
And this pull request also changes
.circleci/config.yml
to deploy alpine based images asmozilla/sops:3.5.0-alpine
andmozilla/sops:alpine
.I believe we don't need alpine images for every commits and only images for tags are enough useful.