Skip to content

Conversation

mariasenosiain
Copy link
Collaborator

@mariasenosiain mariasenosiain commented Mar 30, 2022

Purpose

Fix issue when return to SDK from Digital IDs

External References (e.g. Jira / Zeplin / Confluence)

YM-26133

Approach

Remove use of pending intent extras.

Scope of changes

ReceiverActivity intent management.

Checklist

Requirements

Yoti App production version installed with phone attributes available to share (your Yoti personal account)

  • Dev testing passed
  1. Execute sample-app-3.
  2. Any SDK theme is valid, tap on the Button and complete the attribute share in Yoti App.

EXP: we return to Yoti Button SDK and result is "Success" (green bar appears on top of the session data)

`ReceiverActivity` is launched as a PendingIntent with no extras (check `KernelSDKIntentService`) so it does not make sense to try to handle the intent extras on `ReceiverActivity`, and it was causing the crash when we tried to get the extras to put them in another intent as they're always null.

Related to YM-26133
Related to YM-26133
@pedrojtmartins
Copy link

@mariasenosiain We have the other PR updating it to 1.3.2. Might be worth targeting that one? Or use 1.3.3 instead.

@mariasenosiain
Copy link
Collaborator Author

@mariasenosiain We have the other PR updating it to 1.3.2. Might be worth targeting that one? Or use 1.3.3 instead.

Yeah, I know, but yours cannot be tested because it is going to crash unless you use this one as a base branch :) So, better to update your PR to bump up version to 1.3.3 I think. This one should be merged first into master.

Copy link

@pedrojtmartins pedrojtmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@mariasenosiain mariasenosiain merged commit 19bac26 into master Apr 1, 2022
@mariasenosiain mariasenosiain deleted the YM-26133 branch April 1, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants