Skip to content

Conversation

echarrod
Copy link
Contributor

@echarrod echarrod commented Oct 4, 2017

Changed to version 2.0.0, after addition of X-SDK headers and added keywords. Similar to the .NET version, I decided to be consistent with the versioning there - even though we've changed the name of the package and could feasibly start at 1.0.0 as it's a new package, there is a smaller chance of confusion if we use 2.0.0. I'll publish the package once this change is approved.

Vasile Zaremba and others added 2 commits October 4, 2017 16:26
…and added keywords. Similar to the .NET version, I decided to be consistent with that - even though we've changed the name of the package, there is a smaller chance of confusion if we bump the version to 2.0.0
@echarrod echarrod self-assigned this Oct 4, 2017
@echarrod echarrod requested a review from zarembas October 4, 2017 16:33
@echarrod
Copy link
Contributor Author

echarrod commented Oct 4, 2017

I'll change the readme in this PR too, so I'll be adding at least another commit to it

@echarrod
Copy link
Contributor Author

echarrod commented Oct 4, 2017

I'll also change the install command which is in the integration guide documentation once the package has been published

@zarembas
Copy link
Contributor

zarembas commented Oct 5, 2017

Having the version number consistent across the SDKs would be ideal, but I think it's quite hard to achieve, especially since we will have bugfix releases for individual issues. I'm not that bothered about it.

@echarrod
Copy link
Contributor Author

echarrod commented Oct 5, 2017

It wasn't really the version number consistent across the SDKs that I was talking about - that would be very hard to do! I was talking about the consistency (with .NET) in naming this version 2.0.0, even though technically it could be 1.0.0, as it's a new package.

@zarembas
Copy link
Contributor

zarembas commented Oct 5, 2017

Removed my commit from master. It has already been pulled into this branch. It looks a bit weird to me, but hopefully, it's all good now. There are also a few references to the old package name in the examples.

@echarrod
Copy link
Contributor Author

echarrod commented Oct 5, 2017

I've added requirements changes for the example projects in that last commit. There are instances of import "yoti_python_sdk" in the README and the example projects, but these refer to the internal folder name in the project.

@echarrod
Copy link
Contributor Author

echarrod commented Oct 9, 2017

After having a lot of issues with uploading the new package (SO Issue ,
SourceForge Issue, I managed to get it working!

@echarrod echarrod merged commit 6b6859b into master Oct 9, 2017
@echarrod echarrod deleted the rename-to-yoti branch October 9, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants