Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show diff if it exists #22

Merged
merged 5 commits into from
Apr 6, 2021
Merged

Only show diff if it exists #22

merged 5 commits into from
Apr 6, 2021

Conversation

ctbur
Copy link
Contributor

@ctbur ctbur commented Mar 29, 2021

If the script fails, diff would be unassigned, but still accessed.

@ctbur ctbur requested a review from inverse March 29, 2021 13:17
inverse
inverse approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@inverse inverse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Worth a changelog entry and tagging a new release?

@inverse inverse merged commit f7fe163 into master Apr 6, 2021
@inverse inverse deleted the unassigned-var branch April 6, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inverse inverse inverse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctbur @inverse