Add Missing readme and gradle jar #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akos-hrvth
reviewed
Feb 19, 2025
akos-hrvth
reviewed
Feb 19, 2025
costash
reviewed
Feb 19, 2025
costash
approved these changes
Feb 19, 2025
shaheenanas
reviewed
Feb 19, 2025
|
|
||
| ## Requirements | ||
| * JDK 21 |
There was a problem hiding this comment.
can you add minimal instructions on how to quickly install the JDK?
There was a problem hiding this comment.
Respectfully, I'd be concerned about needing to tell prospective engineers how to install the JDK. It could be googled quite easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gradle-wrapper.jarwas missing, adding it so candidates can run the project using Gradle Wrapper