Skip to content

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Jun 19, 2024

🚀 This description was created by Ellipsis for commit efe616c

Summary:

Replaced MemoryGetRequestMemoryType with MemoryType across the codebase, updating imports and function parameters accordingly.

Key points:

  • Replaced MemoryGetRequestMemoryType with MemoryType in src/zep_cloud/__init__.py.
  • Removed MemoryGetRequestMemoryType import from src/zep_cloud/memory/__init__.py.
  • Updated get method in src/zep_cloud/memory/client.py to use MemoryType.
  • Deleted src/zep_cloud/memory/types/__init__.py and src/zep_cloud/memory/types/memory_get_request_memory_type.py.
  • Added MemoryType import in src/zep_cloud/types/__init__.py.
  • Created src/zep_cloud/types/memory_type.py defining MemoryType.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to efe616c in 57 seconds

More details
  • Looked at 158 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_2OR9QcCNDjQ2WX0V


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Member

@danielchalef danielchalef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paul-paliychuk paul-paliychuk merged commit b85f8f9 into main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants