handle pydantic v1 gracefully #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to eb13b98 in 49 seconds
More details
- Looked at
162lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_m2T0RR6pEfAVqMRM
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to da6ded8 in 52 seconds
More details
- Looked at
236lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/zep_cloud/external_clients/memory.py:76
- Draft comment:
The version check for Pydantic is implemented correctly to ensure compatibility with version 2.0 or greater. This is crucial for maintaining the functionality that depends on the newer features of Pydantic. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a version check for Pydantic in the MemoryClient and AsyncMemoryClient classes to ensure compatibility with Pydantic version 2.0 or greater. This is done by comparing the current Pydantic version with a minimum required version. If the version is less than the required, a RuntimeError is raised. This is a good practice to ensure that the necessary features of Pydantic are available for the application to function correctly. However, the PR also modifies the extractor module to handle cases where Pydantic v2 is not available by defining a custom classPandanticV2Requiredthat raises a RuntimeError when instantiated. This approach ensures that any attempt to use the model classes without the required Pydantic version will immediately alert the developer or user about the missing dependency. This is a proactive approach to dependency management and helps prevent runtime issues due to version mismatches.
Workflow ID: wflow_A2pxPxtQQAEgULsR
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
paul-paliychuk
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added Pydantic version check and handling for absence of Pydantic v2 in
MemoryClient.extractandAsyncMemoryClient.extractmethods.Key points:
MemoryClient.extractandAsyncMemoryClient.extractinsrc/zep_cloud/external_clients/memory.py.RuntimeErrorif Pydantic version is less than 2.0.src/zep_cloud/extractor/__init__.pyto handle absence of Pydantic v2.PydanticV2Requiredclass insrc/zep_cloud/extractor/__init__.pyto raiseRuntimeErrorwhen instantiated.Generated with ❤️ by ellipsis.dev