-
Notifications
You must be signed in to change notification settings - Fork 24
Update Add Facts request object #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/zep_cloud/core/client_wrapper.py # src/zep_cloud/memory/client.py
# Conflicts: # src/zep_cloud/core/client_wrapper.py # src/zep_cloud/memory/client.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 56273ca in 33.224753 seconds
More details
- Looked at
140
lines of code in5
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/zep_cloud/types/added_fact.py:10
- Draft comment:
The implementation of theAddedFact
type and its integration into theadd_session_facts
method appears correct and well-implemented. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a new typeAddedFact
and updates theadd_session_facts
method inMemoryClient
to use this new type instead of a sequence of strings. This change is reflected in both synchronous and asynchronous versions of the method. The PR also updates the SDK version in the headers from 1.0.8 to 1.0.9. The changes are consistent across the files and correctly implemented as per the PR description. There are no apparent issues with the implementation of the new type or its usage in the method.
Workflow ID: wflow_BhVWIN5M9UYXUqpq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 4bb402a in 25.780339 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. pyproject.toml:3
- Draft comment:
Version update to1.0.9
is correctly reflected here. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions that the SDK version was incremented to1.0.9
. The diff provided in the PR description confirms this change in thepyproject.toml
file. This is a standard practice for version management in Python projects using Poetry, where the version number is incremented in the project'spyproject.toml
file to reflect new changes or updates in the package.
Workflow ID: wflow_2XUvyfDl8zG6sckr
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
Updated
add_session_facts
method to useAddedFact
type and incremented SDK version to1.0.9
.Key points:
AddedFact
class insrc/zep_cloud/types/added_fact.py
.add_session_facts
method insrc/zep_cloud/memory/client.py
to useAddedFact
type.add_session_facts
method insrc/zep_cloud/memory/client.py
to useAddedFact
type.1.0.9
insrc/zep_cloud/core/client_wrapper.py
.1.0.9
inpyproject.toml
.Generated with ❤️ by ellipsis.dev