Skip to content

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Oct 31, 2024

Important

Update version to 2.0.1, rename classes, add parameters to clients, and remove LICENSE file.

  • Version Update:
    • Update version to 2.0.1 in pyproject.toml and client_wrapper.py.
  • Class Renames:
    • Rename SessionFactRatingExamples to ApidataFactRatingExamples.
    • Rename SessionFactRatingInstruction to ApidataFactRatingInstruction.
  • Client Changes:
    • Add fact_rating_instruction parameter to add() and update() methods in GroupClient and UserClient.
    • Change return type of delete_fact() in MemoryClient to SuccessResponse.
  • Model Changes:
    • Make content and created_at required in Episode.
    • Deprecate fact field in Fact.
    • Deprecate id field in Group and Session.
  • Miscellaneous:
    • Remove LICENSE file.

This description was created by Ellipsis for 7670b44. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7670b44 in 1 minute and 0 seconds

More details
  • Looked at 718 lines of code in 14 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/zep_cloud/__init__.py:9
  • Draft comment:
    FactRatingExamples and FactRatingInstruction are imported but not used. Consider removing these imports if they are no longer needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR involves renaming and restructuring of classes, particularly around fact rating instructions and examples. The changes seem consistent across the files, but there is a potential issue with the import statements in src/zep_cloud/__init__.py. The FactRatingExamples and FactRatingInstruction are imported but not used, which might be a leftover from the refactoring process.

Workflow ID: wflow_MTC2JTVe4PhjtHZt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit e864ca8 into main Oct 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant