Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image hash should include Zola version #2066

Closed
theMarina opened this issue Jan 3, 2023 · 2 comments
Closed

Image hash should include Zola version #2066

theMarina opened this issue Jan 3, 2023 · 2 comments
Assignees
Labels
done in pr Already done in a PR enhancement

Comments

@theMarina
Copy link

I had Zola version v0.15.3 and updated it to v0.16.1. The old version had a bug where the processed images were black and white which was fixed with the update. However, because Zola caches the images, it did not automatically fix the cached images.

I think that the images should contain information about the Zola version that generated them so they are regenerated if there is an update.
Additionally, I do not like that the image names of the resized images are hashed and do not contain the original image name at all. I think this is bad for SEO

@Keats
Copy link
Collaborator

Keats commented Jan 3, 2023

We could name them {original_hash}.hash.{ext}? I don't think the hash should contain the zola version though, some people have a huge amount of images and they don't want to re-process them on every Zola update. It's easy to do as an opt-in feature though, just delete the processed folder and let Zola re-do it

@Keats Keats self-assigned this Jan 25, 2023
Keats added a commit that referenced this issue Jan 25, 2023
Keats added a commit that referenced this issue Jan 27, 2023
* Refactor image proc

Closes #2066

* Add colocated_path to shortcodes

Closes #1793
@Keats Keats added the done in pr Already done in a PR label Jan 27, 2023
@Keats
Copy link
Collaborator

Keats commented Jan 27, 2023

I've gone with {file_steam}.{hash}.{ext}

@Keats Keats closed this as completed in 8ba6c1c Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done in pr Already done in a PR enhancement
Projects
None yet
Development

No branches or pull requests

2 participants