Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in headers for Github GraphQL example #2229

Closed
Aonrud opened this issue Jun 9, 2023 · 2 comments · Fixed by #2230
Closed

Error in headers for Github GraphQL example #2229

Aonrud opened this issue Jun 9, 2023 · 2 comments · Fixed by #2230

Comments

@Aonrud
Copy link
Contributor

Aonrud commented Jun 9, 2023

Documentation issue

Summary

The example using load_data() to fetch from the Github GraphQL API has an authentication header. The header for sending the token should be authorization as per the Github documentation.

Proposed solution

Update overview.md (line 472) to use authorization instead in case anyone else lazily cuts and pastes the example as a starting point (like I did!) and gets a failed query.

@Keats
Copy link
Collaborator

Keats commented Jun 9, 2023

A PR would be nice!

@Aonrud
Copy link
Contributor Author

Aonrud commented Jun 9, 2023

Apologies – that was a bit lazy! :)

Sent a PR to master since it's a documentation correction.

Keats pushed a commit that referenced this issue Jun 9, 2023
biodranik pushed a commit to biodranik/zola that referenced this issue Sep 12, 2023
technimad pushed a commit to technimad/zola that referenced this issue Sep 30, 2023
Drodt pushed a commit to DerDrodt/zola that referenced this issue Oct 10, 2023
fredr pushed a commit to fredr/zola that referenced this issue Oct 21, 2023
selfisekai pushed a commit to selfisekai/zola that referenced this issue Nov 3, 2023
Newbytee pushed a commit to Newbytee/zola that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants