docs: filter to main for example GH Pages config #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Jan 3, 2022
| @@ -43,6 +43,7 @@ name: Build and deploy GH Pages | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| if: github.ref == 'refs/heads/main' | |||
There was a problem hiding this comment.
can we just point out that this branch name might change depending on the person in the docs below?
There was a problem hiding this comment.
Sorry about the delayed response! Let me know if the second commit is sufficient 🙂
|
Oops, that third commit serves me right for not checking 😅 Happy to squash the commits if that makes your life easier! |
mwcz
pushed a commit
to mwcz/zola
that referenced
this pull request
Jan 7, 2022
* docs: filter to main for example GH Pages config * docs: update GH Pages wording to indicate choice of branch * docs: typo fix
thomasantony
pushed a commit
to thomasantony/zola
that referenced
this pull request
Sep 17, 2022
* docs: filter to main for example GH Pages config * docs: update GH Pages wording to indicate choice of branch * docs: typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
This just bit me - the example configuration for automatically building and deploying your website on GitHub Pages doesn't filter for the main branch, so my draft branch ended up being deployed...
Pretty simple fix, shouldn't cause any issues 🙂