Fix extra syntaxes when highlight_theme = "css" #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, init_extra_syntaxtes_and_highlight_themes will supress loading anything if highlight_theme is "css". This makes sense for the highlight themes, but will also skip loading any extra syntax definitions too. This change defers the theme = css check, so we still load syntaxes in this case. Fixes: getzola#1723 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
|
We may still want to suppress the highlight theme load with highlight_theme = "css" - let me know if there's a better approach here. |
|
I think this is fine as is. It would be nice to have a test for it but I can't remember if that's easy to set up |
Keats
pushed a commit
that referenced
this pull request
Jan 22, 2022
Currently, init_extra_syntaxtes_and_highlight_themes will supress loading anything if highlight_theme is "css". This makes sense for the highlight themes, but will also skip loading any extra syntax definitions too. This change defers the theme = css check, so we still load syntaxes in this case. Fixes: #1723 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Keats
pushed a commit
that referenced
this pull request
Jan 23, 2022
Currently, init_extra_syntaxtes_and_highlight_themes will supress loading anything if highlight_theme is "css". This makes sense for the highlight themes, but will also skip loading any extra syntax definitions too. This change defers the theme = css check, so we still load syntaxes in this case. Fixes: #1723 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
thomasantony
pushed a commit
to thomasantony/zola
that referenced
this pull request
Sep 17, 2022
…zola#1732) Currently, init_extra_syntaxtes_and_highlight_themes will supress loading anything if highlight_theme is "css". This makes sense for the highlight themes, but will also skip loading any extra syntax definitions too. This change defers the theme = css check, so we still load syntaxes in this case. Fixes: getzola#1723 Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, init_extra_syntaxtes_and_highlight_themes will supress
loading anything if highlight_theme is "css". This makes sense for the
highlight themes, but will also skip loading any extra syntax
definitions too.
This change defers the theme = css check, so we still load syntaxes in
this case.
Fixes: #1723
Signed-off-by: Jeremy Kerr jk@codeconstruct.com.au
Sanity check:
Code changes
nextbranch?If the change is a new feature or adding to/changing an existing one: