Make ignored_content work with nested paths and directories #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may break some config files if they had a filter which included directories (like |
Keats
force-pushed
the
next
branch
2 times, most recently
from
189c37d to
6238b36
Compare
|
Can you rebase the PR? |
|
Better now? |
|
Hm no, it still contains lots of unrelated commits from master. The easiest way would be reset --hard on master and cherrypick the 2 relevant commits on it rather than merging |
|
Is it somewhat better now? |
Just had to remove strip_prefix(path) from file ignore code. Added tests for subdirectory globbing.
Keats
requested changes
Jan 29, 2022
to confim that simple filename globs still match paths without strip_prefix
|
Done? GitHub still shows "Changes requested" even if I marked it as resolved, so I'm not sure. |
Keats
pushed a commit
that referenced
this pull request
Feb 14, 2022
* Make ignored_content work with directories Just had to remove strip_prefix(path) from file ignore code. Added tests for subdirectory globbing. * Add documentation * add more tests to confim that simple filename globs still match paths without strip_prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
resolves #1701
Sanity check:
Code changes
nextbranch?If the change is a new feature or adding to/changing an existing one: