Update to elasticlunr-rs 3.0.0 #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
May 23, 2022
| #[cfg(feature = "indexing-ja")] | ||
| Language::Japanese => pipeline::tokenize_japanese, | ||
| _ => pipeline::tokenize, | ||
| }; |
There was a problem hiding this comment.
Additional languages gated by features work automatically now?
There was a problem hiding this comment.
Tokenization is now included in the language trait.
There was a problem hiding this comment.
Looks good then, I'll merge it when 3.0 is released
mattico
changed the title
Keats
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning to release elasticlunr-rs 3.0.0 soon. The one noticeable change for you is the new
IndexBuilder::add_field_with_tokenizerfunction.I wanted to give a chance for feedback before I release the final version.