Strip binary artifact when building for release #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmm ... I didn't notice that the CI uses an old version of Cargo (1.57) which does not yet support the @Keats opinions? Should we hold this change until Cargo is updated or would it make sense to update cargo in the CI (assuming it can be done, I'm not familiar with Azure stuff) |
|
We can update the pinned version |
|
"we" as in "us Zola maintaners"? If so, that would be great. Or is this an actionable for me? :) |
|
The royal we ;) |
Keats
pushed a commit
that referenced
this pull request
Aug 14, 2022
* Strip binary artifact when building for release * Update rustc toolchain to 1.59 for Ubuntu in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discourse (thread).
thanks!