Get term fn #1964
Merged
Get term fn #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Aug 16, 2022
| @@ -180,6 +180,23 @@ items: Array<TaxonomyTerm>; | |||
|
|
|||
| See the [Taxonomies documentation](@/documentation/templates/taxonomies.md) for a full documentation of those types. | |||
|
|
|||
| ### `get_term` | |||
There was a problem hiding this comment.
can we call it get_taxonomy_term?
There was a problem hiding this comment.
Sure. I'll rename in next day or so.
|
@Keats updated as requested. |
Keats
requested changes
Aug 22, 2022
|
|
||
| `lang` (optional) default to `config.default_language` in config.toml | ||
|
|
||
| `include_pages` (optional) default to true. If false, the `pages` item in the `TaxonomyTerm` is replaced with `page_count`, an integer with the number of pages for this term. |
There was a problem hiding this comment.
looking at it again, I think page_count should be additional field that is always passed and this arguments just make pages an empty array.
Keats
approved these changes
Aug 24, 2022
|
Thanks! |
Keats
pushed a commit
that referenced
this pull request
Feb 16, 2023
* Add new `get_taxonomy_term` global function * Update per @Keats feedback to make `page_count` available all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1897, this adds a new
get_termglobal function which returns a singleTaxonomyTermitem instead of the entire site. In the personal site discussed in that issue, this results in a 4x improvement in rendering speed (5.4s vs 22.1s).Code changes
nextbranch?If the change is a new feature or adding to/changing an existing one: