-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion subcommand #1968
Conversation
Honestly I'm kind of wondering if it's even worth adding considering how few commands zola has. |
IMO even two commands is a good reason to have them, and |
If I may be permitted to add my opinion. It is always wonderful if a program supports completions. It's not required but a pleasant surprise if you find out it's available. If there are no material downsides I would say this is a nice thing to add. Are there any notable disadvantages to having this added? I did note that some things needed to be commented out but I didn't quite understand what they were. PS. I've really come to appreciate how careful @Keats is with regard to what is added. I can't tell for sure but it makes it seem like you have a vision for the project and you try to keep it on that vision while being open to other people's ideas. You never just shoot things down without a reason. Even like this you gave your reasoning why you are reluctant. Kudos to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try locally later to see how it works in practice
If we merge this, I'd point it out in the changelog that the scripts in |
Let's remove them in that PR, they haven't been updated in years anyway. |
27c06a9
to
132e757
Compare
132e757
to
63bb6ad
Compare
Thanks! |
* Add completion subcommand * Remove old completion scripts * Move completion logic
There seem to have been a few attempts at completions in the past, but generating from a subcommand seems to be the most versatile for both users and package maintainers. Maybe the old manually written completion scripts could be ditched as well for simplicity?
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
next
branch?If the change is a new feature or adding to/changing an existing one: