Reduced cachebust fingerprint to be more reasonable #2074
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a full 256-bit hash for cachebusting is complete overkill (and a waste of pagesize bytes). It isn't for security, simply to invalidate the browser cache if the file changes.
I've changed it to 80 bits. Since you'll see on average a collision from a collection of n elements after sqrt(n) random samples, this means you'd have to do 2^40 edits on the same file, with the browser caching all of them, before you would load a stale version. That is, even if you edited your CSS file every second and cached all of them for eternity it would still take you ~34865 years before seeing a collision. I think that's plenty.
So instead of this:
You would see: