fix zola serve not respecting preserve_dotfiles_in_output
#2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
approved these changes
Feb 23, 2023
Keats
pushed a commit
that referenced
this pull request
Feb 24, 2023
* fix `zola serve` not respecting `preserve_dotfiles_in_output`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behaviour of
zola serveto respect thepreserve_dotfiles_in_outputconfiguration option. Currently the output -dir is always deleted when the user presses "Ctrl+C" and serve exits. It was an oversight when addingpreserve_dotfiles_in_outputin #1985 .Things to discuss:
clean_site_output_folder()function. Isutils::fsthe right place for it?Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?