Hard link serve panic fix #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
May 4, 2023
components/utils/src/fs.rs
Outdated
| } | ||
| } | ||
| if let Err(e) = std::fs::hard_link(src, dest) { | ||
| console::error(&format!("File System Error, src: {:?}, dst: {:?}", src, dest)); |
There was a problem hiding this comment.
No need to import console, just return an error for both
Raymi306
force-pushed
the
hard-link-serve-panic-fix
branch
from
1848091 to
f95b4f5
Compare
Keats
requested changes
May 5, 2023
components/utils/src/fs.rs
Outdated
| std::fs::hard_link(src, dest)? | ||
| if dest.exists() { | ||
| std::fs::remove_file(dest) | ||
| .with_context(|| format!("Error removing file, dst: {:?}", dest))?; |
There was a problem hiding this comment.
dst is not going to be clear to the end error, just put Error removing file: {:?}
components/utils/src/fs.rs
Outdated
| .with_context(|| format!("Error removing file, dst: {:?}", dest))?; | ||
| } | ||
| std::fs::hard_link(src, dest) | ||
| .with_context(|| format!("Error linking file, src: {:?}, dst: {:?}", src, dest))?; |
There was a problem hiding this comment.
Error linking file -> Error hard linking file
peterprototypes
pushed a commit
to peterprototypes/zola
that referenced
this pull request
Sep 12, 2023
* Fix hard link panic and add better error info to std:fs errors * cargo fmt * Remove erroneously committed config change * Remove console import; Use with context to provide additional error info * improve error wording
technimad
pushed a commit
to technimad/zola
that referenced
this pull request
Sep 30, 2023
* Fix hard link panic and add better error info to std:fs errors * cargo fmt * Remove erroneously committed config change * Remove console import; Use with context to provide additional error info * improve error wording
Keats
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Fix hard link panic and add better error info to std:fs errors * cargo fmt * Remove erroneously committed config change * Remove console import; Use with context to provide additional error info * improve error wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one:
Fixes #2081