-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atom template authors #2259
Atom template authors #2259
Conversation
Ouch, I started the code from the |
Atom 1.0 [0] support multiple `<author>` entries in the feed. This commit modified the template to generate as many `<author>` as the page's metadata contains. [0] https://validator.w3.org/feed/docs/atom.html#recommendedEntryElements
7f5351c
to
db9cd54
Compare
Can you add some tests? |
I can :) |
This file https://github.com/getzola/zola/blob/master/components/site/tests/site.rs is a giant integration test loading this site https://github.com/getzola/zola/tree/master/test_site |
48b6acf
to
e3f677a
Compare
Thanks! That's a very neat test suite. I extended the Rust post to have 3 authors, here's its Atom section:
|
e3f677a
to
805bbb5
Compare
@Keats do you think I should add anything to the documentation? For example, what gets added to the atom/rss feed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat, thanks!
* templates:atom: add support for multiple authors Atom 1.0 [0] support multiple `<author>` entries in the feed. This commit modified the template to generate as many `<author>` as the page's metadata contains. [0] https://validator.w3.org/feed/docs/atom.html#recommendedEntryElements * Test we can have multiple authors in ATOM feeds
* templates:atom: add support for multiple authors Atom 1.0 [0] support multiple `<author>` entries in the feed. This commit modified the template to generate as many `<author>` as the page's metadata contains. [0] https://validator.w3.org/feed/docs/atom.html#recommendedEntryElements * Test we can have multiple authors in ATOM feeds
* templates:atom: add support for multiple authors Atom 1.0 [0] support multiple `<author>` entries in the feed. This commit modified the template to generate as many `<author>` as the page's metadata contains. [0] https://validator.w3.org/feed/docs/atom.html#recommendedEntryElements * Test we can have multiple authors in ATOM feeds
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
next
branch?If the change is a new feature or adding to/changing an existing one:
Atom 1.0 [0] support multiple
<author>
entries in the feed. This commit modified the template to generate as many<author>
as the page's metadata contains.Forum post: https://zola.discourse.group/t/why-the-default-feed-templates-only-use-the-first-author/1738
[0] https://validator.w3.org/feed/docs/atom.html#recommendedEntryElements