Allow ignoring files when link checking #2264
Conversation
|
I will address the test failures soon |
|
Hi @Raymi306 , are you still planning on addressing them? |
|
I apologize for the delay, I will look into this soon |
Raymi306
force-pushed
the
zola-check-exclude-directories-#2239
branch
from
d8f5c3f to
762b404
Compare
|
I did some updating of my fork and some cherrypicking to try and get this PR back in to shape. |
|
I note that components/site/link_checking has no tests and is rather monolithic, might be worth a "todo" comment to refactor the code to make it easier to test chunks of? |
| @@ -105,6 +106,10 @@ fn should_skip_by_prefix(link: &str, skip_prefixes: &[String]) -> bool { | |||
| skip_prefixes.iter().any(|prefix| link.starts_with(prefix)) | |||
| } | |||
|
|
|||
| fn should_skip_by_file(file_path: &Path, glob_set: &GlobSet) -> bool { | |||
There was a problem hiding this comment.
not sure it's worth a fn if it's only used once in this file
There was a problem hiding this comment.
should_skip_by_prefix was my point of reference here, it also is only used once in this file.
would you like me to remove both?
|
Thanks! |
* Allow ignoring files when link checking * cargo fmt * Fix tests * Remove mystery duplicate function..? * Add in some mysterious missing code..? * Simple tests for link checker file globs in config * cargo fmt * Remove comment * convert expect to error propagation * Address comments * cargo fmt
* Allow ignoring files when link checking * cargo fmt * Fix tests * Remove mystery duplicate function..? * Add in some mysterious missing code..? * Simple tests for link checker file globs in config * cargo fmt * Remove comment * convert expect to error propagation * Address comments * cargo fmt
* Allow ignoring files when link checking * cargo fmt * Fix tests * Remove mystery duplicate function..? * Add in some mysterious missing code..? * Simple tests for link checker file globs in config * cargo fmt * Remove comment * convert expect to error propagation * Address comments * cargo fmt
For #2239
IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.
The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: