Simple console error message dialog in zola serve webpages
#2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Sep 20, 2023
| let html_error = format!( | ||
| r#"<div style="all:revert;position:fixed;display:flex;align-items:center;justify-content:center;background-color:rgb(0,0,0,0.5);top:0;right:0;bottom:0;left:0;"><div style="background-color:white;padding:0.5rem;border-radius:0.375rem;filter:drop-shadow(0,25px,25px,rgb(0,0,0/0.15));overflow-x:auto;"><p style="font-weight:700;color:black;font-size:1.25rem;margin:0;margin-bottom:0.5rem;">Zola Build Error:</p><pre style="padding:0.5rem;margin:0;border-radius:0.375rem;background-color:#363636;color:#CE4A2F;font-weight:700;">{error_str}</pre></div></div>"# | ||
| ); | ||
| bytes.extend(html_error.as_bytes()); |
There was a problem hiding this comment.
Can we get some invalid HTML generated by inserting after </html>?
There was a problem hiding this comment.
Yes, this way is technically invalid HTML, but it worked on all the browsers I tested it on. If that's too much of a problem I can try to remove </html> before appending the message box 🤔
There was a problem hiding this comment.
If it works on all browsers it's fine, not the weirdest HTML they will see
|
Thanks! |
technimad
pushed a commit
to technimad/zola
that referenced
this pull request
Sep 30, 2023
…#2312) * first attempt at injecting HTML into outgoing webpages * finish error handling * fix test_site debug line
Drodt
pushed a commit
to DerDrodt/zola
that referenced
this pull request
Oct 10, 2023
…#2312) * first attempt at injecting HTML into outgoing webpages * finish error handling * fix test_site debug line
fredr
pushed a commit
to fredr/zola
that referenced
this pull request
Oct 21, 2023
…#2312) * first attempt at injecting HTML into outgoing webpages * finish error handling * fix test_site debug line
selfisekai
pushed a commit
to selfisekai/zola
that referenced
this pull request
Nov 3, 2023
…#2312) * first attempt at injecting HTML into outgoing webpages * finish error handling * fix test_site debug line
Newbytee
pushed a commit
to Newbytee/zola
that referenced
this pull request
Dec 19, 2023
…#2312) * first attempt at injecting HTML into outgoing webpages * finish error handling * fix test_site debug line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2303.
This PR creates a mutable static error variable in
crate::cmd::serve, and inserts a console-like error message dialog onto all outgoing HTML responses. The actual implementation is a little sub-optimal, but it's the best I could do considering two different threads have to share state between 4+ nestedFnMut()s.I tried to make the message dialog as neutral as possible, if there are any zola-specific styles it should have, let me know :)