Add multi-stage dockerfile build example #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Oct 11, 2023
| FROM ghcr.io/static-web-server/static-web-server:2 | ||
| WORKDIR / | ||
| COPY --from=zola /project/public /public | ||
| ``` |
There was a problem hiding this comment.
That part should not be in the installation doc, it's running the output side in a docker container
There was a problem hiding this comment.
Should I just remove that part ?
Or do you think there is a better place in the documentation where to put the whole example ?
Cutting the Dockerfile just after the build is possible, but the resulting image is a bit useless in itself.
There was a problem hiding this comment.
Maybe put it in the deploy section?
oleastre
force-pushed
the
multi-stage-build
branch
from
79a2676 to
2b0a10d
Compare
selfisekai
pushed a commit
to selfisekai/zola
that referenced
this pull request
Nov 3, 2023
* Add multi-stage dockerfile build example * Simplify install instructions, add docker image deployment example
Newbytee
pushed a commit
to Newbytee/zola
that referenced
this pull request
Dec 19, 2023
* Add multi-stage dockerfile build example * Simplify install instructions, add docker image deployment example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
This is a simple documentation improvement proposal to add an example how to use the zola docker image in a multi stage build.
This should answers questions like #1319 and avoid workaround like creating derived docker images.