Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to updated version of checkout action #2340

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

c-git
Copy link
Contributor

@c-git c-git commented Oct 28, 2023

I think we should update to the new version of checkout in the example. The current example is pinned to a very old version of checkout. I also just pinned it to version 4 instead of 4.0.0 so the documentation doesn't require updates as often to be up to date. That's also how they show it in the example in their readme.

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

Small change, was easier to do than to explain what I wanted to do. Less time investment than creating an issue (to ensure in include all required context).

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@Keats
Copy link
Collaborator

Keats commented Oct 29, 2023

Can you do the PR on the next branch?

@c-git
Copy link
Contributor Author

c-git commented Oct 29, 2023

Yes I can rebase it

Edit: Actually just realized that's not necessary just create a new PR.

@c-git c-git closed this Oct 29, 2023
@c-git c-git deleted the patch-1 branch October 29, 2023 18:33
@c-git c-git restored the patch-1 branch October 29, 2023 18:43
@c-git c-git reopened this Oct 29, 2023
@c-git
Copy link
Contributor Author

c-git commented Oct 29, 2023

That's cool, I deleted the branch but there was a restore button so I could just reopen it.

@Keats Keats merged commit 152eccc into getzola:master Oct 29, 2023
1 of 5 checks passed
@c-git c-git deleted the patch-1 branch October 29, 2023 19:26
selfisekai pushed a commit to selfisekai/zola that referenced this pull request Nov 3, 2023
Newbytee pushed a commit to Newbytee/zola that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants