Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GitLab Pages documentation #2384

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Update the GitLab Pages documentation #2384

merged 7 commits into from
Dec 21, 2023

Conversation

walpox
Copy link
Contributor

@walpox walpox commented Dec 20, 2023

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Rationale

  1. What's stated in the section Repository setup seems to be outdated. As per the current documentation on GitLab, GitLab Pages does not seem to work the way described there.
  2. In the GitLab CI template, the only keyword is no longer supported by GitLab. Its replacement is rules.
  3. The GitLab CI template can be changed to allow using specific versions of Zola.
  4. Rewritten some parts as per my personal writing style.
  5. Some other changes were proposed by my Markdown linter, such as removing the dollar signs from the fenced code blocks.
  6. Removed comments that described what a command does, instead of the why.

@Keats Keats merged commit 38199c1 into getzola:master Dec 21, 2023
5 checks passed
@Keats
Copy link
Collaborator

Keats commented Dec 21, 2023

Thanks

stanistan pushed a commit to stanistan/zola that referenced this pull request Jan 2, 2024
* docs: update gitlab-pages.md

* docs: rephrase sentence

* docs: add clarification

* docs: fix formatting

* docs: add link to gitlab docs

* docs: update gitlab-pages-md

* docs: refactor gitlab-pages.md
gamingrobot pushed a commit to gamingrobot/zola that referenced this pull request Jan 5, 2024
* docs: update gitlab-pages.md

* docs: rephrase sentence

* docs: add clarification

* docs: fix formatting

* docs: add link to gitlab docs

* docs: update gitlab-pages-md

* docs: refactor gitlab-pages.md
veluca93 pushed a commit to veluca93/zola that referenced this pull request May 14, 2024
* docs: update gitlab-pages.md

* docs: rephrase sentence

* docs: add clarification

* docs: fix formatting

* docs: add link to gitlab docs

* docs: update gitlab-pages-md

* docs: refactor gitlab-pages.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants