Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more information about Vercel deployments #2399

Merged
merged 3 commits into from
Jan 7, 2024
Merged

Add more information about Vercel deployments #2399

merged 3 commits into from
Jan 7, 2024

Conversation

ysfchn
Copy link
Contributor

@ysfchn ysfchn commented Jan 3, 2024

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

My first attempt for getting Zola to work in Vercel didn't succeed, because apparently Vercel's own build images has older glibc version than Zola requires, which also reported on #1713 and https://github.com/orgs/vercel/discussions/3181.

However, I managed to get it working by setting Node.js version to "20.x" in Vercel project settings, and I used a custom command to download the latest binary from GitHub instead of using Vercel's own version of Zola, so I wanted to include this information in the documentation in case anyone needs.

### Prefer clean URLs

When enabled, all HTML files will be served without their file extension, so visitors will see
`/about` instead of `/about.html` while navigating through your website.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There won't be a about.html file with zola, how does that work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, it is meant to be an example to tell how it works, I forgot to indicate that it is an example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the sentence, hope it's better now.

### Prefer clean URLs

When enabled, all HTML files will be served without their file extension. For example
if you have an `about.md` file, Zola will generate a `about.html` file, but Vercel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zola will generate a about.html

No, Zola will generate about/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was an oversight on my part, I forgot how it works for a moment 😅 Fixed.

@Keats Keats merged commit b3c9529 into getzola:master Jan 7, 2024
5 checks passed
@Keats
Copy link
Collaborator

Keats commented Jan 7, 2024

Thanks!

veluca93 pushed a commit to veluca93/zola that referenced this pull request May 14, 2024
* Add more information about Vercel

* Change wording and add specify version

* Update vercel.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants