Refactor: remove even more unnecessary create_directory #2428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next
branch?These are some things that were missed even by #2407.
After doing some more investigation, even copying files will automatically create directories, so, we don't need these calls either. It simplifies the code a bit more and will also ensure that directories aren't created unless files are actually inside them.
Another reason for this change is it also makes calls to
write_content
andwrite_section
a bit less confusing, since right now, if multiple calls to it are made, the final argument is set tofalse
to avoid doing work, which can make following the code a bit more challenging since it's not always clear when this argument is applied.One small change here: this adds the same create-parent logic to
create_file
ascopy_file
andcopy_file_if_needed
, so that these three methods are consistent. Part of the reason why these were necessary before was because directories had to be manually created sometimes, and this was a bit inconsistent, so, this PR fixes that.