Fix link check report inconsistency #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veluca93
pushed a commit
to veluca93/zola
that referenced
this pull request
May 14, 2024
* Fix link check report inconsistency * Fix formatting issue --------- Co-authored-by: Tanishq <tanishq@levels.fyi>
Keats
pushed a commit
that referenced
this pull request
Jun 20, 2024
* Fix link check report inconsistency * Fix formatting issue --------- Co-authored-by: Tanishq <tanishq@levels.fyi>
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
* Fix link check report inconsistency * Fix formatting issue --------- Co-authored-by: Tanishq <tanishq@levels.fyi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2412
Root Cause
In the first log we are removing duplicate links by using HashSet but in the second log we were counting all links
Tests
Skipped tests cause this is a logging issue and does not affects the functionality