fix ignore links to #top when checking anchors #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
reviewed
Jun 11, 2024
components/content/src/utils.rs
Outdated
| // HTML specs state a special anchor: "top" (case-insensitive) | ||
| // which is used to refer to the start of the page | ||
| // https://html.spec.whatwg.org/#select-the-indicated-part | ||
| if anchor.eq_ignore_ascii_case("top") { |
There was a problem hiding this comment.
Is it the right place to do it? This checks for the anchors in the heading, it feels like this check should be before calling that function.
Keats
approved these changes
Jun 12, 2024
Keats
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix ignore links to #top when checking anchors * move logic to check internal links --------- Co-authored-by: Tanishq <tanishq@levels.fyi>
berdandy
pushed a commit
to berdandy/azola
that referenced
this pull request
Sep 17, 2024
* fix ignore links to #top when checking anchors * move logic to check internal links --------- Co-authored-by: Tanishq <tanishq@levels.fyi>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2495