Readme update #776
Comments
|
Related to #542 |
|
related to #942 |
|
I think this is done already? |
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this issue
Apr 1, 2021
* Add Error State to Storages fix gfx-rs#772 * use resize function in insert * address review comments
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this issue
Apr 1, 2021
779: Fix hub insertion r=kvark a=kvark **Connections** Fixes gfx-rs#778 Follow-up to gfx-rs#776 **Description** Problem was `resize_with` takes new length, not a difference. **Testing** Untested Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this issue
Apr 1, 2021
782: Add check while trying to remove uninserted Ids r=kvark a=kunalmohan **Connections** _Link to the issues addressed by this PR, or dependent PRs in other repositories_ An attempt to fix gfx-rs#781 regression from gfx-rs#776 **Description** _Describe what problem this is solving, and how it's solved._ When we used `VecMap`, it simply returned `None` for even out of bounds access to the map (We depended on it returning `None`). After gfx-rs#776 , we get a panic. So adding a simple index check before accessing it fixes this issue. **Testing** _Explain how this change is tested._ Tested on wgpu-rs examples with the changes in gfx-rs/wgpu-rs#430. All examples run fine except the `cube` which segfaults. <!-- Non-trivial functional changes would need to be tested through: - [wgpu-rs](https://github.com/gfx-rs/wgpu-rs) - test the examples. - [wgpu-native](https://github.com/gfx-rs/wgpu-native/) - check the generated C header for sanity. Ideally, a PR needs to link to the draft PRs in these projects with relevant modifications. See gfx-rs/wgpu#666 for an example. If you can add a unit/integration test here in `wgpu`, that would be best. --> Co-authored-by: Kunal Mohan <kunalmohan99@gmail.com>
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this issue
Apr 1, 2021
783: Basic use of Error for bind groups r=kvark a=kvark **Connections** Follow up to gfx-rs#776 **Description** Trying to tidy up a few things and add a public use of `Error` variant **Testing** not tested Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this issue
Apr 1, 2021
857: Separate valid internal IDs from external ones r=cwfitzgerald a=kvark **Connections** Closes gfx-rs#638 wgpu-rs update - gfx-rs/wgpu-rs#494 **Description** The core change here is to allow user-specified IDs to be in the "Error" state that was introduced in gfx-rs#776 . This is done by defining an internal `Valid<I>` wrapper. Now, the hub storages can be indexed by this valid wrapper only. For regular IDs, we have to go through `storage.get(index)`, which returns a `Result`. It still panics if the ID is totally garbage though, we don't want to handle what can't be expected here. All the other changes come mostly as a consequence of that: - new "Invalid*" error variants are added - the error types are undergone sever refactoring - new `command/draw.rs` module for stuff shared between render passes and bundles - functions to generate error IDs for all the types - various renames, e.g. `comb` -> `cmd_buf` The expected use by wgpu-rs is unchanged. So far, I don't think we'd be generating Error IDs, but we can always reconsider. For browsers though, if `device_create_xxx` failed, they would generate and error ID. It will occupy the slot up until the corresponding JS object is dropped. **Testing** Tested on wgpu-rs examples Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
DocumentationlinkGetting startedinfo and linksWho is using itwithhematiteand project linksNotessectionBonus points for updating the organization icon.
The text was updated successfully, but these errors were encountered: