Add web backend #193

grovesNL · 2020-03-10T12:49:54Z

This branch has a bunch of WIP changes as I work through #101

The branch is still very unstable but any feedback about the approach so far would be great.

I tried to use a backend trait initially (with associated types and functions) but it didn't work great here. For example, async fn can't be used on traits yet.

Instead, with the current approach we have to manually ensure that all type signatures match. This seems mostly ok because we wrap most types/functions in wgpu-rs anyway, but we do have to be careful wherever we directly expose types. For example, if an exposed type is Copy in one backend and not the other, we'd probably have to newtype them (probably relevant for all of the XyzId types).

kvark

It's both sad and relieving that we can't use a trait:

sad because it's harder to guarantee the implementations match perfectly
relieving because the users don't need to suffer :)

examples/hello-compute/main.rs

src/backend/web.rs

grovesNL · 2020-03-12T04:06:36Z

I was able to run hello-compute in Firefox Nightly with the latest changes (top wasm, bottom native):

grovesNL · 2020-03-15T01:43:39Z

And now hello-triangle is able to run on the web too:

(it's upside-down due to gfx-rs/wgpu#519)

mitchmindtree · 2020-03-15T08:38:26Z

examples/hello-triangle/main.rs

@@ -60,7 +62,7 @@ async fn run() {
        }),
        primitive_topology: wgpu::PrimitiveTopology::TriangleList,
        color_states: &[wgpu::ColorStateDescriptor {
-            format: wgpu::TextureFormat::Bgra8UnormSrgb,
+            format: wgpu::TextureFormat::Bgra8Unorm,


Oh interesting. Is it now the case that Bgra8Unorm is assumed to be sRGB?

Nope both Bgra8Unorm and Bgra8UnormSrgb still exist – this is just a temporary hack for the hello-triangle example because Chrome Canary didn't seem to allow me to use Bgra8UnormSrgb for the swapchain :) I haven't looked into it yet but a swapchain with Bgra8UnormSrgb is supposed to work fine in browsers as far as I know.

204: Return futures from request adapter/request device r=kvark a=grovesNL Relevant to #175 Backporting some parts of #193 for async request adapter and async request device. Co-authored-by: Joshua Groves <josh@joshgroves.com>

Songtronix · 2020-03-17T07:50:51Z

If you want to use async traits there is async-trait. Supports a wide range of usecases but has it's limitations.

grovesNL · 2020-04-04T02:44:02Z

msaa-line and boids are working now too

grovesNL · 2020-04-05T14:22:40Z

The next working example is cube:

grovesNL · 2020-04-06T01:51:02Z

Skybox!

monocodus

This is autogenerated code-style review, new suggestions: 14

examples/cube/main.rs

examples/mipmap/main.rs

examples/shadow/main.rs

examples/skybox/main.rs

grovesNL · 2020-04-12T17:11:34Z

All examples are available at http://joshgroves.com/gfx/wgpu/examples/?example=hello-triangle for now.

Each example is built in debug and much larger than the final wasm files will be (built in release/stripped of unused symbols). There are also still some issues with the winit integration, so the wasm file has to be fully loaded before sending any events to the canvas. ControlFlow::Poll isn't being used yet so interaction (e.g. by moving the cursor over the canvas) is needed to continue the event loop.

Both Chrome Canary and Firefox Nightly have issues running all examples at the moment, but eventually all examples should work fine 🤞

monocodus

This is autogenerated code-style review, new suggestions: 14

examples/cube/main.rs

examples/mipmap/main.rs

examples/shadow/main.rs

examples/skybox/main.rs

expenses · 2020-04-12T17:25:59Z

Both Chrome Canary and Firefox Nightly have issues running all examples at the moment, but eventually all examples should work fine crossed_fingers

No luck on Safari here either.

grovesNL · 2020-04-12T17:29:25Z

@expenses I also forgot to mention that these examples are currently using SPIR-V, which won't work in Safari. We'll eventually need to support WGSL here, which will allow Safari to run them (once WebGPU support is ready in Safari in general)

monocodus

This is autogenerated code-style review, new suggestions: 4

examples/shadow/main.rs

grovesNL · 2020-04-18T03:19:38Z

bors r=kvark

grovesNL · 2020-04-18T03:33:33Z

@kvark I need to merge this manually due to https://forum.bors.tech/t/resource-not-accessible-by-integration/408/3 – I'm updating the CI actions but bors isn't allowed to merge those changes

Keavon · 2020-04-18T03:36:46Z

🎉

grovesNL · 2020-04-18T03:45:04Z

For anyone interested in continuing to follow the progress here, I'll keep updating the examples at http://joshgroves.com/gfx/wgpu/examples/.

Some of the recent fixes from @kvark should be landing in Firefox Nightly soon (enable WebGPU using the instructions above) which should get most of these examples working.

Keavon · 2020-04-19T00:59:47Z

Should Currently wgpu-rs works on native platforms, but WASM support is currently being added as well. be removed from the project's readme?

grovesNL · 2020-04-19T02:39:11Z

@Keavon yeah, we should be able to remove that and clarify that both native and wasm are supported now 👍 Would you like to submit a PR to update it?

Keavon · 2020-04-19T02:44:38Z

I haven't been following this closely enough to know what would be most appropriate to write so I'd probably feel better not doing the PR myself.

grovesNL · 2020-04-19T02:53:44Z

Maybe we could replace it with something like

wgpu-rs can be run both natively (using wgpu-core and gfx-hal) and on the web (using the WebGPU API from wasm).

grovesNL mentioned this pull request Mar 11, 2020

Move some types into shared wgpu-types crate gfx-rs/wgpu#514

Merged

kvark reviewed Mar 11, 2020

View reviewed changes

examples/hello-compute/main.rs Outdated Show resolved Hide resolved

src/backend/web.rs Show resolved Hide resolved

mitchmindtree reviewed Mar 15, 2020

View reviewed changes

grovesNL mentioned this pull request Mar 16, 2020

[meta] Async all the things #175

Closed

4 tasks

grovesNL force-pushed the wasm1 branch 2 times, most recently from f33513d to 4c2744b Compare March 16, 2020 11:21

grovesNL mentioned this pull request Mar 16, 2020

Return futures from request adapter/request device #204

Merged

grovesNL force-pushed the wasm1 branch from 4c2744b to 1084bbd Compare March 17, 2020 01:56

grovesNL force-pushed the wasm1 branch 2 times, most recently from 1565ef7 to 4545236 Compare March 27, 2020 03:05

grovesNL force-pushed the wasm1 branch from 4545236 to c504bbd Compare April 4, 2020 02:45

grovesNL force-pushed the wasm1 branch from 34b9101 to 7d84bd6 Compare April 11, 2020 14:11

monocodus bot suggested changes Apr 11, 2020

View reviewed changes

grovesNL force-pushed the wasm1 branch from 7d84bd6 to 0e6a72a Compare April 12, 2020 17:15

monocodus bot suggested changes Apr 12, 2020

View reviewed changes

grovesNL force-pushed the wasm1 branch from 0e6a72a to a10c2e3 Compare April 12, 2020 22:21

monocodus bot suggested changes Apr 12, 2020

View reviewed changes

examples/shadow/main.rs Outdated Show resolved Hide resolved

examples/shadow/main.rs Outdated Show resolved Hide resolved

examples/shadow/main.rs Outdated Show resolved Hide resolved

examples/shadow/main.rs Outdated Show resolved Hide resolved

grovesNL force-pushed the wasm1 branch from a10c2e3 to 03f8b10 Compare April 13, 2020 00:37

monocodus bot approved these changes Apr 13, 2020

View reviewed changes

grovesNL force-pushed the wasm1 branch from 546757c to 392084e Compare April 18, 2020 02:11