Fix Subgroup Ops on VK 1.2 Device

gfx-rs · Apr 29, 2024 · 0a79002 · 0a79002
1 parent 4521502
commit 0a79002
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -39,6 +39,12 @@ Bottom level categories:
 
 ## Unreleased
 
+### Bug Fixes
+
+#### Vulkan
+
+- Fix enablement of subgroup ops extension on Vulkan devices that don't support Vulkan 1.3. By @cwfitzgerald in [#5624](https://github.com/gfx-rs/wgpu/pull/5624).
+
 ## v0.20.0 (2024-04-28)
 
 ### Major Changes

diff --git a/wgpu-hal/src/vulkan/adapter.rs b/wgpu-hal/src/vulkan/adapter.rs
@@ -952,8 +952,8 @@ impl PhysicalDeviceProperties {
                 extensions.push(vk::ExtImageRobustnessFn::name());
             }
 
-            // Require `VK_EXT_subgroup_size_control` if the associated feature was requested
-            if requested_features.contains(wgt::Features::SUBGROUP) {
+            // Require `VK_EXT_subgroup_size_control` if it is available
+            if self.supports_extension(vk::ExtSubgroupSizeControlFn::name()) {
                 extensions.push(vk::ExtSubgroupSizeControlFn::name());
             }
         }