Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer constant pointers for descriptors? #20

Closed
grovesNL opened this issue Oct 4, 2018 · 0 comments · Fixed by #21
Closed

Prefer constant pointers for descriptors? #20

grovesNL opened this issue Oct 4, 2018 · 0 comments · Fixed by #21
Labels
type: question Further information is requested

Comments

@grovesNL
Copy link
Collaborator

grovesNL commented Oct 4, 2018

We shouldn't need to copy descriptors to control ownership on the Rust side, so I think it might generally be more efficient to accept const WGPUDeviceDescriptor *desc for example.

However for the remote use case, how do we need to handle descriptors, or binary data in general? Do we assume all of these will exist in shared memory and we get pointers directly to them? Or would descriptors be serialized?
@grovesNL grovesNL added the type: question Further information is requested label Oct 4, 2018
@grovesNL grovesNL mentioned this issue Oct 12, 2018
Merged
bors bot added a commit that referenced this issue Oct 12, 2018
@bors @grovesNL
Merge #21
bcf51a6 
21: Use pointers for descriptors r=kvark a=grovesNL

(Mostly) fixes #20

I didn't try to handle the remote case yet, but it will need serialization as we mentioned.

Co-authored-by: Joshua Groves <josh@joshgroves.com>
@bors bors bot closed this as completed in #21 Oct 12, 2018
@grovesNL grovesNL mentioned this issue Oct 14, 2018
Closed
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this issue Feb 23, 2020
@bors @rukai
Merge gfx-rs#20
05e9dfd 
20: Update to latest wgpu-native r=kvark a=rukai



Co-authored-by: Rukai <rubickent@gmail.com>
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
@bors @rukai
[rs] Merge gfx-rs#20
0815d99 
20: Update to latest wgpu-native r=kvark a=rukai



Co-authored-by: Rukai <rubickent@gmail.com>
cwfitzgerald pushed a commit that referenced this issue Oct 26, 2023
@bors @kvark
Merge #20
0643df0 
20: Preparations for 0.3 release r=msiglreith a=kvark

Including:
- rename feature "libstatic" to "implicit-link"
- Debug and constructor implementations for the library structs
- removal of redundant Heap definition

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Wumpf pushed a commit that referenced this issue Feb 9, 2024
@ErichDonGubler
Revert "docs: inline document-features usage, remove dep." (#5169)
f21087d 
* docs: sync. `wgpu/Cargo.toml` feature comments with `lib.rs`

* Revert "docs: inline `document-features` usage, remove dep."

This reverts commit 3d5bec6, with an
update to `document-features`, and preferring to keep new `feature`
content. To be clear, the only difference I have observed is the
addition of the `serde` feature.

In case it shortens anyone's search, the specific issue resolved is
[`slint-ui/document-features`#20](slint-ui/document-features#20).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pointers for descriptors
1 participant
@grovesNL