-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-borrowing rust bindings #68
Comments
It would be surprising for user that assume unique ownership to find out copies of his resources because another crate in dependency graph enabled that feature. |
@omni-viral good point (although, again, it's not critical - it's not making the library unsafe). We should make it so that situation is impossible. The point of providing a feature here is not to allow different clients to enabled or disable it, but to keep the same code base. |
I see what you mean. But this means user can't rely on uniqueness of the resource id if he gives a reference to it somewhere. |
68: remove usages of wgn in examples r=kvark a=rukai This slipped through in gfx-rs/wgpu-rs#67 Co-authored-by: Rukai <rubickent@gmail.com>
68: remove usages of wgn in examples r=kvark a=rukai This slipped through in gfx-rs/wgpu-rs#67 Co-authored-by: Rukai <rubickent@gmail.com>
Superseded by #1453. |
Allow `Application` configuration with `Settings`
Related to #37 , also commentary from @omni-viral
Our current Rust bindings assume unique ownership over the IDs. This is idiomatic but sometimes inconvenient for the clients that need more freedom. Since our native layer is safe, we can have the IDs copyable on the Rust level as well, it's just going to be slightly different kind of API.
It would be nice not to fragment the community with another Rust wrapper. Perhaps, we can just control it by a feature? I.e.
The text was updated successfully, but these errors were encountered: