Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VK_FORMAT_R8G8B8A8_SRGB is not a supported vertex buffer format #99

Closed
lain-dono opened this issue Mar 11, 2019 · 2 comments
Closed

VK_FORMAT_R8G8B8A8_SRGB is not a supported vertex buffer format #99

lain-dono opened this issue Mar 11, 2019 · 2 comments
Labels
type: bug Something isn't working

Comments

@lain-dono
Copy link
Contributor

When I try to use wgpu::VertexAttributeDescriptor with format wgpu::VertexFormat::Ushort2Norm, I get the error:

ERROR 2019-03-11T01:06:21Z: gfx_backend_vulkan: [Validation] [ VUID-VkVertexInputAttributeDescription-format-00623 ] Object: VK_NULL_HANDLE (Type = 0) | vkCreateGraphicsPipelines: pCreateInfo[0].pVertexInputState->vertexAttributeDescriptions[2].format (VK_FORMAT_R8G8B8A8_SRGB) is not a supported vertex buffer format. The Vulkan spec states: format must be allowed as a vertex buffer format, as specified by the VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT flag in VkFormatProperties::bufferFeatures returned by vkGetPhysicalDeviceFormatProperties (https://www.khronos.org/registry/vulkan/specs/1.1-extensions/html/vkspec.html#VUID-VkVertexInputAttributeDescription-format-00623)

I think that it is:

UcharNorm => H::R8Srgb,
Uchar2Norm => H::Rg8Srgb,
Uchar3Norm => H::Rgb8Srgb,
Uchar4Norm => H::Rgba8Srgb,
Uchar4NormBgra => H::Bgra8Srgb,

Should be like this:

        UcharNorm => H::R8Unorm, 
        Uchar2Norm => H::Rg8Unorm, 
        Uchar3Norm => H::Rgb8Unorm, 
        Uchar4Norm => H::Rgb8Unorm, 
        Uchar4NormBgra => H::Bgra8Unorm, 
bors bot added a commit that referenced this issue Mar 11, 2019
100: Fix vertex format mapping r=kvark a=lain-dono

Patch for #99.

Co-authored-by: Lain-dono <lain.dono@gmail.com>
@kvark
Copy link
Member

kvark commented Mar 11, 2019

Thanks for filing the issue and fixing it!
btw, it's a convention to say "fixes #xxxx" in your PR description, which tells Github to automatically close the associated issue upon merging

@kvark kvark added the type: bug Something isn't working label Mar 11, 2019
@kvark
Copy link
Member

kvark commented Mar 24, 2019

Fixed by #100

@kvark kvark closed this as completed Mar 24, 2019
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this issue Feb 23, 2020
99: Update dependencies (including wgpu commit) r=kvark a=rukai



Co-authored-by: Rukai <rubickent@gmail.com>
kvark pushed a commit to kvark/wgpu that referenced this issue Jun 3, 2021
99: Update dependencies (including wgpu commit) r=kvark a=rukai



Co-authored-by: Rukai <rubickent@gmail.com>
RandyMcMillan pushed a commit to RandyMcMillan/wgpu that referenced this issue Jun 19, 2024
Schedule render after `Command` futures finish in `iced_web`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants