-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update render pass and framebuffers logic to the latest gfx-hal #1147
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated code review.
Checker summary (by rust_clippy):
The tool has found 83 warnings, 0 errors.
Out of curiosity, tried this, and in my project I get part of the viewport cut off after resizing the window to "extreme-ish" aspect ratio. I did a xcode frame cap, and when the view is cut off, I see there is a I wonder if it is the The behaviour seems to be if width is less than some fixed size, then height is cut to that fixed size, and vice versa, if height is less than some fixed size, width is cut at some fixed size. |
Wow, @scoopr that's amazing feedback! I'll check it out. |
Everything is fixed, and even better than before! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but otherwise LGTM!
Thank you for reviewing! |
Connections
Updates gfx-hal with the latest major changes of gfx-rs/gfx#3571
Description
There is no need to track framebuffers at all any more! Since they don't contain images, we can keep them permanently.
There is no need to create and delete framebuffers for the swapchain either. Lots of non-trivial code is gone 🎉
The PR also removes one of the mutexes that the device holds.
Testing
Will be tested on wgpu-rs