Add cts_runner and deno_webgpu crate #1859

lucacasonato · 2021-08-24T19:10:26Z

This PR is a WIP.

@kvark and I discussed how wgpu could run tests against cts. CTS is built on the JS API. gfx-rs/wgpu only has a Rust API. One possible solution that was suggested is to use Deno's implementation of WebGPU JS API.

Deno implements the glue bindings between the WebGPU JS API, and the Rust wgpu-core.

The PR adds the deno_webgpu crate from denoland/deno, and a simple cts_runner runtime which only purpose is to run CTS tests.

To try ou the cts runner with a basic compute example:

cargo run -p cts_runner -- cts_runner/examples/hello-compute.js

kvark

Thank you for doing this!

My main concern here is the amount of duplicated code. If it was possible to auto-generate, say, texture formats from a single place, that would help quite a bit. I guess if it was possible, you'd already be doing something like this...

Another question is - what is Deno's plan here? Would you include the whole wgpu as a sub-module? That's quite a bit of code!

Finally, this marked as WIP. What is missing?

deno_webgpu/webgpu.idl

deno_webgpu/texture.rs

Cargo.lock

cts_runner/Cargo.toml

cts_runner/build.rs

lucacasonato · 2021-08-30T20:25:18Z

My main concern here is the amount of duplicated code. If it was possible to auto-generate, say, texture formats from a single place, that would help quite a bit. I guess if it was possible, you'd already be doing something like this...

It is possible, and we are considering it. WebGPU has by far the largest API surface of the web APIs we implement (so many types!), so we are sorta pushing this into the future. At some point I want to properly auto generate much JS boilerplate from WebIDL. The same could probably be done for all the enums in wgpu_types.

Another question is - what is Deno's plan here? Would you include the whole wgpu as a sub-module? That's quite a bit of code!

So this gets a little complicated. We have two constraints that we are dealing with from the Deno side:

we publish the final deno binary target to crates.io - this requires that all dependencies are also published on crates.io
deno_core lives in the same repo as deno, and they are published in sync. deno_webgpu has a dependency on deno_core, but is a dependant of deno.

I propose we do the following:

all crates that already exist in this repo now, and are published to crates.io (wgpu_types, wgpu_core, wgpu) are published from this repo like is done now (nothing changes here)
deno_webgpu canonically lives in this repo, but it is not tagged or released here (more on this later)
deno_webgpu periodically updates to newer deno_core releases from crates.io to mostly stay up to date with the main deno tree
we vendor (submodule or otherwise) deno_webgpu into the deno tree
- we float a patch keeping deno_core pinned to the in tree version
- we use the version of wgpu_core and friends that is published to crates.io
- we might also occasionally need to float patches to deal with changes in deno_core
deno_webgpu will be published to crates.io in sync with deno releases from the vendored crate living in the deno tree
we update the vendored deno_webgpu in the deno tree whenever a new release of wgpu_core is published

Finally, this marked as WIP. What is missing?

I want to make sure this implementation can run at least 1 CTS test correctly. Actual CTS infra can be set up in a follow up.

kvark · 2021-08-31T20:28:48Z

Looks to be ready now, thank you!
But let's not merge until we can talk over the long term plan her. ETA this Friday

kvark

Results from talking about this on a call:

the TS bindings can be moved out
build script can be removed
still want to get the first CTS test running before landing

cts_runner binaries are now not portable anymore. Also startup will now print a bunch of cargo:rerun-if-changed=. This will be fixed in deno_core.

lucacasonato · 2021-09-03T15:08:54Z

And got CTS working (with these changes to cts: gpuweb/cts#734)

~/p/g/g/cts ❯❯❯ /Users/lucacasonato/projects/github.com/gfx-rs/wgpu/target/debug/cts_runner ./tools/run_deno 'unittests:*'
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/core/00_primordials.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/core/01_core.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/core/02_error.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/webidl/00_webidl.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/console/01_colors.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/console/02_console.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/url/00_url.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/00_infra.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/01_dom_exception.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/01_mimesniff.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/02_event.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/02_structured_clone.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/03_abort_signal.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/04_global_interfaces.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/05_base64.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/06_streams.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/08_text_encoding.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/09_file.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/10_filereader.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/11_blob_url.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/12_location.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/web/13_message_port.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/timers/01_timers.js
cargo:rerun-if-changed=/Users/lucacasonato/.cargo/git/checkouts/deno-22855de1c03c9128/ca75752/ext/timers/02_performance.js
cargo:rerun-if-changed=/Users/lucacasonato/projects/github.com/gfx-rs/wgpu/deno_webgpu/01_webgpu.js
cargo:rerun-if-changed=/Users/lucacasonato/projects/github.com/gfx-rs/wgpu/deno_webgpu/02_idl_types.js
cargo:rerun-if-changed=/Users/lucacasonato/projects/github.com/gfx-rs/wgpu/cts_runner/src/bootstrap.js

** Summary **
Passed  w/o warnings = 110 / 110 = 100.00%
Passed with warnings =   0 / 110 =   0.00%
Skipped              =   0 / 110 =   0.00%
Failed               =   0 / 110 =   0.00%

lucacasonato · 2021-09-03T15:12:39Z

Due to the removal of build.rs, startup will now print a bunch of cargo:rerun-if-changed= lines. This is a bug in deno_core, which I'll get fixed soon. Just an aesthetic thing, so shouldn't prevent this PR from landing.

kvark · 2021-09-03T17:17:10Z

Ok, this is wonderful. Looks like we are all set now?

lucacasonato · 2021-09-03T17:21:58Z

Yup, I think so!

WIP: add cts_runner and deno_webgpu crate

6a4b00e

lucacasonato force-pushed the cts_runner branch from 7011fe2 to 6a4b00e Compare August 24, 2021 19:13

kvark reviewed Aug 25, 2021

View reviewed changes

kvark mentioned this pull request Aug 25, 2021

Run WebGPU CTS on CI #1421

Closed

lucacasonato mentioned this pull request Aug 30, 2021

Implement serde::Deserialize on wgpu_types types, following names from WebGPU JS API #1887

Closed

lucacasonato added 6 commits August 31, 2021 11:08

add test

ad3d5f0

remove Cargo.lock

b6cf782

Merge remote-tracking branch 'origin/master' into cts_runner

70474bb

review comment

11c6b1e

Merge remote-tracking branch 'origin/master' into cts_runner

b1f6b81

simplify

f116fe7

kvark approved these changes Aug 31, 2021

View reviewed changes

lucacasonato added 3 commits September 3, 2021 13:50

fix bugs

bea5d37

improve cts_runner to work with crowlKats/webgpu-examples

b3eae4c

fix

008e96d

kvark reviewed Sep 3, 2021

View reviewed changes

lucacasonato added 2 commits September 3, 2021 16:56

remove build.rs

3d7e90c

cts_runner binaries are now not portable anymore. Also startup will now print a bunch of cargo:rerun-if-changed=. This will be fixed in deno_core.

remove d.ts

3c3f81e

add original deno license file

04e98bc

kvark merged commit d5ba0b4 into gfx-rs:master Sep 3, 2021

kvark changed the title ~~WIP: add cts_runner and deno_webgpu crate~~ Add cts_runner and deno_webgpu crate Sep 3, 2021

This was referenced Sep 3, 2021

Enable WebGPU CTS on CI #1903

Merged

API tracing is broken with new enums #1931

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cts_runner and deno_webgpu crate #1859

Add cts_runner and deno_webgpu crate #1859

lucacasonato commented Aug 24, 2021 •

edited

Loading

kvark left a comment

lucacasonato commented Aug 30, 2021 •

edited

Loading

kvark commented Aug 31, 2021

kvark left a comment

lucacasonato commented Sep 3, 2021

lucacasonato commented Sep 3, 2021

kvark commented Sep 3, 2021

lucacasonato commented Sep 3, 2021

Add cts_runner and deno_webgpu crate #1859

Add cts_runner and deno_webgpu crate #1859

Conversation

lucacasonato commented Aug 24, 2021 • edited Loading

kvark left a comment

Choose a reason for hiding this comment

lucacasonato commented Aug 30, 2021 • edited Loading

kvark commented Aug 31, 2021

kvark left a comment

Choose a reason for hiding this comment

lucacasonato commented Sep 3, 2021

lucacasonato commented Sep 3, 2021

kvark commented Sep 3, 2021

lucacasonato commented Sep 3, 2021

lucacasonato commented Aug 24, 2021 •

edited

Loading

lucacasonato commented Aug 30, 2021 •

edited

Loading