-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xtask
for project workflows, but start small with only run-wasm
#3844
Conversation
61f25e4
to
d5d25b6
Compare
Gonna copy in some discussion from Matrix to here, since this is a better place for topical discussion. @cwfitzgerald asked:
I responded:
|
@cwfitzgerald: I've updated the OP with more notes explaining why we're doing this. The "further work" mentioned in the OP doesn't seem to have any issues I can link to for WebGPU CTS. Should I file one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, filling an issue about CTS test expectations sounds good, plus putting it in the testing tracking issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
G2G after discussed nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Recommended review experience is commit-by-commit.
Checklist
cargo clippy
.RunN/ARUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknown
if applicable.Connections
Link to the issues addressed by this PR, or dependent PRs in other repositories
Description
Describe what problem this is solving, and how it's solved.
cargo-xtask
is a convention for project workflows using a Rust crate that is separate from the main body of code. We've identified some problems that we'd like to solve withxtask
12. This PR doesn't try to address those problems specifically, but it does take on setting upxtask
for further work. It also absorbsrun-wasm
as an easy first bit of scope.xtask
that is aliased in Cargo withcargo xtask
.run-wasm
toxtask
. Notably, this moves the some pieces of the main workspace's dependency graph toxtask
.Args
and newrun_wasm_with_css_with_args
rukai/cargo-run-wasm#37.Testing
Explain how this change is tested.
cargo xtask run-wasm
yields the same running results, but it should.Footnotes
See this conversation about eventually needing to manage test expectations for WebGPU CTS. ↩
See this pain point issue: https://github.com/gfx-rs/wgpu/issues/3680 ↩