Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump js-sys and web-sys to 0.3.65 on v0.18 #4778

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Bump js-sys and web-sys to 0.3.65 on v0.18 #4778

merged 1 commit into from
Nov 27, 2023

Conversation

torokati44
Copy link
Contributor

This is a backport of #4777 to v0.18.
Fixes #4776.

@torokati44 torokati44 requested a review from a team as a code owner November 26, 2023 03:07
Wumpf
Wumpf approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Wumpf Wumpf merged commit e16f7b4 into gfx-rs:v0.18 Nov 27, 2023
27 checks passed
@torokati44
Copy link
Contributor Author

Sorry for all the nagging, I don't want to be too much of a PITA 😶 - but can we expect a v0.18 maintenance release sometime soon, with this in it?

@torokati44
Copy link
Contributor Author

Or, perhaps a better question is, will web-sys 0.3.66 come out soon, following js-sys 0.3.66, and should it wait for that...

@torokati44 torokati44 mentioned this pull request Nov 28, 2023
Merged
@torokati44
Copy link
Contributor Author

Okay, just checked, web-sys 0.3.66 didn't introduce any incompatibilities with 0.3.65 the same way as 0.3.65 did with 0.3.64. So Ruffle should be able to update to 0.3.66 without any further changes to wgpu. Back to waiting for a patch release! 😳

@torokati44 torokati44 mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torokati44 @Wumpf