Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lifetime constraints from wgpu::ComputePass methods #5570

Merged
merged 12 commits into from
May 14, 2024
Merged

Remove lifetime constraints from wgpu::ComputePass methods #5570

merged 12 commits into from
May 14, 2024

Commits on Apr 23, 2024

  1. basic test setup

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    d12ba2c View commit details
    Browse the repository at this point in the history

  2. remove lifetime and drop resources on test - test fails now just as e… 

    …xpected
    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a86ef5c View commit details
    Browse the repository at this point in the history

  3. compute pass recording is now hub dependent (needs gfx_select)

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e39fa3b View commit details
    Browse the repository at this point in the history

  4. compute pass recording now bumps reference count of uses resources di… 

    …rectly on recording

TODO:
* bind groups don't work because the Binder gets an id only
* wgpu level error handling is missing
    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    8af13df View commit details
    Browse the repository at this point in the history

  5. simplify compute pass state flush, compute pass execution no longer n… 

    …eeds to lock bind_group storage
    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2673628 View commit details
    Browse the repository at this point in the history

  6. wgpu sided error handling

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a88a906 View commit details
    Browse the repository at this point in the history

  7. make ComputePass hal dependent, removing command cast hack. Introduce… 

    … DynComputePass on wgpu side
    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    841cfcb View commit details
    Browse the repository at this point in the history

  8. remove stray repr(C)

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4f3f1db View commit details
    Browse the repository at this point in the history

  9. changelog entry

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    5bfef4b View commit details
    Browse the repository at this point in the history

  10. fix deno issues -> move DynComputePass into wgc

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0d470a9 View commit details
    Browse the repository at this point in the history

  11. split out resources setup from test

    @Wumpf
    Wumpf committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    22c1e68 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Merge remote-tracking branch 'origin/trunk' into lifetime-free-comput… 

    …epass
    @Wumpf
    Wumpf committed May 14, 2024
    Configuration menu
    Copy the full SHA
    acc3a04 View commit details
    Browse the repository at this point in the history