Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more internal uses of IDs #5848

Merged
merged 27 commits into from
Jun 20, 2024
Merged

Remove more internal uses of IDs #5848

merged 27 commits into from
Jun 20, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Jun 20, 2024

Part of #5121.

PR doesn't need to be squashed, each commit builds by itself.

teoxoy added 24 commits June 20, 2024 14:24
@teoxoy
replace uses of Id.backend() with A::VARIANT
6129aa8
@teoxoy
remove TextureBindGroupState.add_single's return type
3abcdda
@teoxoy
make clear_texture_via_render_passes infallible (in practice it was…
0b31c06 
… already)
@teoxoy
remove usage of Texture IDs in clear code
6028052
@teoxoy
remove usage of Buffer IDs in clear code
c526332
@teoxoy
use Arc::ptr_eq for resource equality
0ffb66b
@teoxoy
use the tracker index as key in hashmap instead of ID
ee121b4
@teoxoy
use error_ident for log instead of ID
aca802d
@teoxoy
make check_buffer_usage a buffer method
8be0ac9
@teoxoy
make check_texture_usage a texture method
a37e4bd
@teoxoy
simplify BufferTracker.set_single's return type
696d98e
@teoxoy
remove IDs from StatelessBindGroupState
e15a249
@teoxoy
take buffer lookup out of BufferBindGroupState.add_single
2b45ae9
@teoxoy
make return type of TextureTracker.set_single non-optional
f47608b
@teoxoy
consolidate destroyed texture/buffer errors and separate them from in…
169115d 
…valid ID errors
@teoxoy
remove old comment
02f508d
@teoxoy
take resource lookup out of StatelessTracker.add_single
6144498
@teoxoy
introduce TextureView.try_raw
a8b89a1
@teoxoy
change BindGroup.raw to BindGroup.try_raw
3ce5eb0
@teoxoy
remove ID from QueueSubmitError::BufferStillMapped
8d65500
@teoxoy
take resource lookup out of BufferUsageScope.merge_single
195b32c
@teoxoy
move body of BufferUsageScope.insert_merge_single in `BufferUsageSc…
6d93677 
…ope.merge_single`
@teoxoy
change return type of ResourceMetadataProvider.get to &Arc<T>
dcab7c6
@teoxoy
remove IDs from UsageConflict variants
8013f07
@teoxoy teoxoy requested a review from a team as a code owner June 20, 2024 12:28
@ErichDonGubler ErichDonGubler self-assigned this Jun 20, 2024
@ErichDonGubler ErichDonGubler added the kind: refactor Making existing function faster or nicer label Jun 20, 2024
@ErichDonGubler

This comment was marked as resolved.

Sign in to view
@teoxoy

This comment was marked as resolved.

Sign in to view
@Wumpf
Copy link
Member

Wumpf commented Jun 20, 2024

nice

@teoxoy teoxoy merged commit 1e784c9 into gfx-rs:trunk Jun 20, 2024
25 checks passed
@teoxoy teoxoy deleted the remove-more-uses-of-ids branch June 20, 2024 14:34
@teoxoy teoxoy assigned teoxoy and unassigned nical and ErichDonGubler Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees

@teoxoy teoxoy

Labels
kind: refactor Making existing function faster or nicer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teoxoy @ErichDonGubler @Wumpf @nical