Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the triage suspected machinery and break cycles with weak refs #5910

Merged
merged 20 commits into from
Jul 9, 2024
Merged

Remove the triage suspected machinery and break cycles with weak refs #5910

merged 20 commits into from
Jul 9, 2024

Commits on Jul 9, 2024

  1. remove unused TempResource::Texture

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    df18fc5 View commit details
    Browse the repository at this point in the history

  2. change prepare_staging_buffer to return a non null u8 pointer

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7675aa1 View commit details
    Browse the repository at this point in the history

  3. use StagingBuffer instead of Buffer for mapped_at_creation Buffers

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    f529af1 View commit details
    Browse the repository at this point in the history

  4. remove unused TempResource::Buffer

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1a10ef4 View commit details
    Browse the repository at this point in the history

  5. remove Device.create_buffer_impl

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    0eec33e View commit details
    Browse the repository at this point in the history

  6. remove Arcs around TempResource variants

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    839d469 View commit details
    Browse the repository at this point in the history

  7. add ActiveSubmission.temp_resources that contains all temporary res… 

    …ources.

It's worth noting that `suspected_resources` never contained those resources.
    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1a4675b View commit details
    Browse the repository at this point in the history

  8. remove device_maintain_ids

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    00a6486 View commit details
    Browse the repository at this point in the history

  9. move trackers into EncoderInFlight on submit

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    da338bf View commit details
    Browse the repository at this point in the history

  10. remove PendingWrites.executing_command_buffers 

    The Vec only ever contained 0 or 1 command buffers.
We now acquire an encoder on every submit for pending writes but that's not a problem since those are coming from a pool anyway.
    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    725c838 View commit details
    Browse the repository at this point in the history

  11. remove LifetimeTracker.future_suspected_{buffers,textures}

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2243a61 View commit details
    Browse the repository at this point in the history

  12. don't check if the buffer is still "present" from the user's perspect… 

    …ive in `LifetimeTracker.handle_mapping`

This change doesn't change behavior as `Global.buffer_drop` already unmaps the buffer.
    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    52a89cf View commit details
    Browse the repository at this point in the history

  13. remove the triage suspected machinery

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d2fbf9b View commit details
    Browse the repository at this point in the history

  14. replace the tracker in Device with a new DeviceTracker

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    77f196a View commit details
    Browse the repository at this point in the history

  15. make resource metadata generic over a T: Clone

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7fa17ff View commit details
    Browse the repository at this point in the history

  16. remove unnecessary PhantomData

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    3deb5cb View commit details
    Browse the repository at this point in the history

  17. remove unused BufferTracker.get()

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c45c2b2 View commit details
    Browse the repository at this point in the history

  18. don't call drain_transitions() of we drop the results

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b3559cd View commit details
    Browse the repository at this point in the history

  19. introduce DeviceBufferTracker which holds weak references to buffers

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ae33a88 View commit details
    Browse the repository at this point in the history

  20. introduce DeviceTextureTracker which holds weak references to textures

    @teoxoy
    teoxoy committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7ba4498 View commit details
    Browse the repository at this point in the history