Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage indexing, framebuffer tracking, and a bunch of validation fixes #77

Merged
merged 9 commits into from
Feb 27, 2019

Conversation

kvark
Copy link
Member

@kvark kvark commented Feb 26, 2019

Closes #73
Closes #75
Closes #79

@kvark kvark requested a review from grovesNL February 26, 2019 16:21
@kvark
Copy link
Member Author

kvark commented Feb 27, 2019

Note: there is a long tail of seemingly unrelated changes here. Mostly incremental improvements.

@@ -224,7 +222,7 @@ pub extern "C" fn wgpu_render_pass_set_pipeline(
}

let pipeline_layout_guard = HUB.pipeline_layouts.read();
let pipeline_layout = pipeline_layout_guard.get(pipeline.layout_id);
let pipeline_layout = &pipeline_layout_guard[pipeline.layout_id];
let bing_group_guard = HUB.bind_groups.read();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just noticed the typo bing here :)

@@ -550,7 +550,9 @@ pub extern "C" fn wgpu_device_create_texture(

pub fn texture_create_view(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem correct long term to accept hal types in pub functions, unless we can somehow guarantee wgpu-remote will be the only consumer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to be a problem if those entry points are not in the headers?

@kvark kvark changed the title Storage indexing and framebuffer tracking Storage indexing, framebuffer tracking, and a bunch of validation fixes Feb 27, 2019
@kvark
Copy link
Member Author

kvark commented Feb 27, 2019

Ok, all Vulkan validation errors are fixed now.
bors r=grovesNL

bors bot added a commit that referenced this pull request Feb 27, 2019
77: Storage indexing, framebuffer tracking, and a bunch of validation fixes r=grovesNL a=kvark

Closes #73
Closes #75
Closes #79

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
@bors
Copy link
Contributor

bors bot commented Feb 27, 2019

Build succeeded

@bors bors bot merged commit 8ad1476 into gfx-rs:master Feb 27, 2019
@kvark kvark deleted the index branch February 27, 2019 15:23
mitchmindtree pushed a commit to mitchmindtree/wgpu that referenced this pull request Feb 23, 2020
77: Modify examples to use PowerPreference::Default r=kvark a=danaugrs



Co-authored-by: Daniel Salvadori <danaugrs@gmail.com>
kvark pushed a commit to kvark/wgpu that referenced this pull request Jun 3, 2021
77: Modify examples to use PowerPreference::Default r=kvark a=danaugrs



Co-authored-by: Daniel Salvadori <danaugrs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants