llama: -fa 1/0/-1 aliases for -fa on/off/auto #15746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
reviewed
Sep 2, 2025
common/arg.cpp
Outdated
| string_format("set Flash Attention use ('on', 'off', or 'auto', default: '%s')", llama_flash_attn_type_name(params.flash_attn_type)), | ||
| [](common_params & params, const std::string & value) { | ||
| if (value == "on" || value == "enabled") { | ||
| if (value == "on" || value == "enabled" || "1") { |
There was a problem hiding this comment.
Suggested change
| if (value == "on" || value == "enabled" || "1") { | |
| if (value == "on" || value == "enabled" || value == "1") { |
Same for the rest.
There was a problem hiding this comment.
Thank you.
JohannesGaessler
force-pushed
the
llama-fa-alias
branch
from
238e427 to
2bd18fe
Compare
slaren
approved these changes
Sep 2, 2025
walidbr
pushed a commit
to walidbr/llama.cpp
that referenced
this pull request
Sep 7, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Oct 7, 2025
This reverts commit c466abe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of habit from
llama-benchI'm trying to set FlashAttention via e.g.-fa 0. This PR adds numeric aliases for on/off/auto.