common : fix Hermes tool-call parser leaking wrapper XML #16377
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has particularly been an issue when trying to use the
qwen-code
CLI in conjunction with llama.cpp - it essentially only works with vLLM for Qwen3-Coder models.changes:
<tool_call>/<tool>
wrappers when parsing Hermes/Qwen function-tag tool calls so they no longer leak into assistant content<function=...>
blocks<tool_call><function=...>
cases with a regression intest-chat.cpp