Skip to content

Conversation

CISC
Copy link
Collaborator

@CISC CISC commented Oct 2, 2025

Not sure what's going on with the (ILLEGAL) failures here, but likely due to ccache (see #16355), try disabling it.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Oct 2, 2025
@ggerganov
Copy link
Member

The alternative is to do as @angt suggested in #16185 (comment). Not sure which is better.

@CISC
Copy link
Collaborator Author

CISC commented Oct 2, 2025

The alternative is to do as @angt suggested in #16185 (comment). Not sure which is better.

The build only takes 5 minutes (and succeeds now), I think we can do without ccache.

@CISC CISC requested a review from ggerganov October 2, 2025 11:08
@ggerganov
Copy link
Member

Could you also disable it for macOS-latest-cmake-arm64? I have no idea why it is failing, but hopefully this will have some effect.

@CISC
Copy link
Collaborator Author

CISC commented Oct 2, 2025

Could you also disable it for macOS-latest-cmake-arm64? I have no idea why it is failing, but hopefully this will have some effect.

I don't think it's the same problem, it looks like test-barrier just takes too long to finish (test-barrier (Timeout)).

@CISC
Copy link
Collaborator Author

CISC commented Oct 2, 2025

Could you also disable it for macOS-latest-cmake-arm64? I have no idea why it is failing, but hopefully this will have some effect.

I don't think it's the same problem, it looks like test-barrier just takes too long to finish (test-barrier (Timeout)).

Though, I see it should not normally take that long:
https://github.com/ggml-org/llama.cpp/actions/runs/18190642032/job/51784711744?pr=16388#step:5:759

I'll do some tests...

@slaren
Copy link
Member

slaren commented Oct 2, 2025

It might be because it is using more threads than physically available. The threadpool is known to be extremely slow in that case.

@ggerganov
Copy link
Member

This should do it:

diff --git a/tests/test-barrier.cpp b/tests/test-barrier.cpp
index d85bf912b..d1a86c473 100644
--- a/tests/test-barrier.cpp
+++ b/tests/test-barrier.cpp
@@ -1,6 +1,5 @@
 #include "ggml.h"
 #include "ggml-cpu.h"
-#include "ggml-backend.h"
 
 #include <chrono>
 #include <iostream>
@@ -8,12 +7,13 @@
 #include <cstdlib>
 #include <cassert>
 #include <vector>
+#include <thread>
 
 #define MAX_NARGS 2
 
 int main(int argc, char *argv[]) {
 
-    int n_threads = 4;
+    int n_threads = std::min(4, (int) std::thread::hardware_concurrency());
     int n_rounds  = 100;
 
     if (argc > 1) {

@CISC CISC merged commit 72ee736 into master Oct 2, 2025
53 of 57 checks passed
@CISC CISC deleted the cisc/ci-ubuntu-latest-cmake-rpc-fix-attempt branch October 2, 2025 11:51
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request Oct 3, 2025
* origin/master: (124 commits)
metal : fix loop bound in ggml_mem_ranges (ggml-org#16412)
llama : fix shapes for bert/mpt q/k norm (ggml-org#16409)
ggml : fix graph reallocation with multiple chunks (ggml-org#16396)
Fix missing messages on sibling navigation (ggml-org#16408)
vulkan: Replace uses of maxMemoryAllocationSize and VK_WHOLE_SIZE (ggml-org#16354)
vulkan: Fix FA coopmat1 invalid array indexing (ggml-org#16365)
ci : change macos-13 to macos-15-intel (ggml-org#16401)
Capture model name only after first token (streaming) or completed request (ggml-org#16405)
vulkan: in flash attention, bounds check against nem1 (don't rely on GGML_KQ_MASK_PAD) (ggml-org#16316)
webui : Fix messages payload sent to chat completions (ggml-org#16402)
fix: track viewportHeight via window.innerHeight to avoid unwanted scrolling (ggml-org#16356)
test-barrier : do not use more threads than physically available (ggml-org#16389)
ggml webgpu: add support for soft_max, optimize rms_norm (ggml-org#16357)
model : Apertus model implementation (ggml-org#15852)
musa: update compile flags (ggml-org#16265)
ci : fix ubuntu-latest-cmake-rpc (disable ccache) (ggml-org#16388)
ci: update vulkan ci (ggml-org#16294)
ci : fix clean-up of old logs (ggml-org#16381)
SYCL: Update to oneAPI 2025.2 (ggml-org#16371)
HIP: add IMbackK to codeowner (ggml-org#16375)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants