Skip to content

Fix missing messages on sibling navigation #16408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2025
+10 −5
Merged

Fix missing messages on sibling navigation #16408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4be1476
fix: resolve message disappearing issue when navigating between regen…
allozaur Oct 3, 2025
0f02fe2
chore: update webui build output
allozaur Oct 3, 2025
632ab99
Merge remote-tracking branch 'origin/master' into 16406-fix-missing-m…
allozaur Oct 3, 2025
db0f79a
chore: update webui build output
allozaur Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified tools/server/public/index.html.gz
View file
Open in desktop
Binary file not shown.
15 changes: 10 additions & 5 deletions tools/server/webui/src/lib/stores/chat.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,15 +860,18 @@ class ChatStore {
this.currentResponse = '';

try {
const assistantMessage = await this.createAssistantMessage();
const parentMessageId =
this.activeMessages.length > 0
? this.activeMessages[this.activeMessages.length - 1].id
: null;

const assistantMessage = await this.createAssistantMessage(parentMessageId);

if (!assistantMessage) {
throw new Error('Failed to create assistant message');
}

this.activeMessages.push(assistantMessage);
await DatabaseStore.updateCurrentNode(this.activeConversation.id, assistantMessage.id);
this.activeConversation.currNode = assistantMessage.id;

const conversationContext = this.activeMessages.slice(0, -1);

Expand Down Expand Up @@ -1124,8 +1127,10 @@ class ChatStore {
(m) => m.role === 'user' && m.parent === rootMessage?.id
);

await DatabaseStore.updateCurrentNode(this.activeConversation.id, siblingId);
this.activeConversation.currNode = siblingId;
const currentLeafNodeId = findLeafNode(allMessages, siblingId);

await DatabaseStore.updateCurrentNode(this.activeConversation.id, currentLeafNodeId);
this.activeConversation.currNode = currentLeafNodeId;
await this.refreshActiveMessages();

// Only show title dialog if we're navigating between different first user message siblings
Expand Down