metal : fix mul-mm condition + fix mul-mv permuted kernels #16494
+44
−35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the
llama-batched-bench
numbers in #16490 (comment) I realized that the wrong Metal kernels were being used for SSM models. Also fix some mv kernels when src0 is permuted.make -j && ./bin/llama-batched-bench -hf unsloth/granite-4.0-h-micro-GGUF:Q4_0 -c 4096 -b 2048 -ub 512 -npp 512 -ntg 128 -npl 1,2,4 -ngl 99 -fa on
Before
After